WIP: remove -msse2 from linux32 builds, use explicit build tag #80
Conversation
|
Yup, now all builds are green, there are manylinux1 and manylinux2010 builds. We should consider reverting this when the 1.18 branch dies in order to boost performance on linux32. The build from pushing the commit to end was 36 minutes. Since this branch is in my fork it did not upload, which might add a bit more time. |
| CFLAGS="-msse2 -std=c99 -fno-strict-aliasing" | ||
| # Causes failure for pre-1.19 in np.reciprocal | ||
| # CFLAGS="-msse2 -std=c99 -fno-strict-aliasing" | ||
| CFLAGS="-std=c99 -fno-strict-aliasing" |
There was a problem hiding this comment.
I hope to get 1.18.4 out using the travis/appveyor system, so this is really an azure testing option. Any idea why the test failures don't show up with travis/appveyor? Once we have things working we can start pointing to numpy master branch for numpy-wheels master, sometimes we want to trigger a nightly build unrelated to cron.
|
Thanks Matti. |
|
The old build system does not use the -msse2 flag |
Ah... |
Checking if removing the -msse2 flag from 32-bit fixes wheel building. Should revert this once the last 1.18 build is done, since the problem is fixed on master and the flag allows faster loops.