Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

Testing if python 3.8 is available. #62

Closed
wants to merge 11 commits into from
Closed

Testing if python 3.8 is available. #62

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
96b450f
Testing if python 3.8 is available.
charris Oct 3, 2019
4a7976f
Update multibuild to latest devel.
charris Oct 4, 2019
c4f5c42
test manylinux2010
charris Oct 4, 2019
1b365bb
Update multibuild to f0bff09.
charris Oct 6, 2019
0d9f0e7
Disable all but 3.8 builds.
charris Oct 6, 2019
0b995f0
Fix .appveyor parse error, maybe.
charris Oct 6, 2019
29c2882
Try another appveyor fix.
charris Oct 6, 2019
374289d
Try latest manylinux1.
charris Oct 7, 2019
53c211d
Be explicit about manylinux version=1
charris Oct 7, 2019
f63ac91
Try i386
charris Oct 7, 2019
e61d303
try again
charris Oct 7, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 15 additions & 15 deletions .appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,25 +26,25 @@ environment:
DAILY_COMMIT: master

matrix:
- PYTHON: C:\Python37
PYTHON_VERSION: 3.7
PYTHON_ARCH: 32
#- PYTHON: C:\Python37
#PYTHON_VERSION: 3.7
#PYTHON_ARCH: 32

- PYTHON: C:\Python37-x64
PYTHON_VERSION: 3.7
PYTHON_ARCH: 64
#- PYTHON: C:\Python37-x64
#PYTHON_VERSION: 3.7
#PYTHON_ARCH: 64

- PYTHON: C:\Python36
PYTHON_VERSION: 3.6
PYTHON_ARCH: 32
#- PYTHON: C:\Python36
#PYTHON_VERSION: 3.6
#PYTHON_ARCH: 32

- PYTHON: C:\Python36-x64
PYTHON_VERSION: 3.6
PYTHON_ARCH: 64
#- PYTHON: C:\Python36-x64
#PYTHON_VERSION: 3.6
#PYTHON_ARCH: 64

- PYTHON: C:\Python35
PYTHON_VERSION: 3.5
PYTHON_ARCH: 32
#- PYTHON: C:\Python35
#PYTHON_VERSION: 3.5
#PYTHON_ARCH: 32

- PYTHON: C:\Python35-x64
PYTHON_VERSION: 3.5
Expand Down
47 changes: 28 additions & 19 deletions .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,30 +32,39 @@ matrix:
# Exclude the default Python 3.5 build
- python: 3.5
include:
#- os: linux
#env:
#- MB_PYTHON_VERSION=3.6
#- os: linux
#env:
#- MB_PYTHON_VERSION=3.6
#- PLAT=i686
#- os: linux
#env:
#- MB_PYTHON_VERSION=3.7
#- os: linux
#env:
#- MB_PYTHON_VERSION=3.7
#- PLAT=i686
- os: linux
env:
- MB_PYTHON_VERSION=3.6
- MB_PYTHON_VERSION=3.8
- MB_ML_VER=1
- os: linux
env:
- MB_PYTHON_VERSION=3.6
- MB_PYTHON_VERSION=3.8
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try here to use the manylinux2010 image by adding MB_ML_VER=2010? In order to use this you will also need to update the multibuild subrepo to the HEAD of the devel branch

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly, it failed at the same spot, it cannot find pip.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did download 2010 however.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The path in the docker image is /opt/python/cp38-cp38, multibuild expects a m suffix /opt/python/cp38-cp38m

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could test locally on ubuntu 18.04 with

##!bash
set -x
REPO_DIR=numpy
        # Also see DAILY_COMMIT below
BUILD_COMMIT=master
BUILD_DEPENDS=cython
TEST_DEPENDS=pytest
PLAT=x86_64
UNICODE_WIDTH=32
WHEELHOUSE_UPLOADER_USERNAME=travis-worker
MB_PYTHON_VERSION=3.8
MB_ML_VER=2010
source multibuild/common_utils.sh
source multibuild/travis_steps.sh
before_install
clean_code $REPO_DIR $BUILD_COMMIT
./patch_code.sh $REPO_DIR
if [ "$TRAVIS_OS_NAME"  == "linux" ]; then
    export CFLAGS=${CFLAGS}" -Wno-sign-compare -Wno-unused-result\
                             -Wno-strict-aliasing";
fi
build_wheel $REPO_DIR $PLAT

and to debug the docker I added set -x to the top of multibuild/docker_build_wrap.sh

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the difference between a python with and without the m suffix?

- MB_ML_VER=1
- PLAT=i686
- os: linux
env:
- MB_PYTHON_VERSION=3.7
- os: linux
env:
- MB_PYTHON_VERSION=3.7
- PLAT=i686
- os: osx
language: generic
env:
- MB_PYTHON_VERSION=3.6
- MB_PYTHON_OSX_VER=10.9
- os: osx
language: generic
env:
- MB_PYTHON_VERSION=3.7
- MB_PYTHON_OSX_VER=10.9
#- os: osx
#language: generic
#env:
#- MB_PYTHON_VERSION=3.6
#- MB_PYTHON_OSX_VER=10.9
#- os: osx
#language: generic
#env:
#- MB_PYTHON_VERSION=3.7
#- MB_PYTHON_OSX_VER=10.9

before_install:
- if [ "$TRAVIS_BRANCH" == "master" ]; then
Expand Down
2 changes: 1 addition & 1 deletion multibuild
Open in desktop
Submodule multibuild updated 9 files
+18 −0 .travis.yml
+22 −3 README.rst
+5 −1 common_utils.sh
+2 −0 configure_build.sh
+2 −2 library_builders.sh
+7 −1 manylinux_utils.sh
+5 −2 osx_utils.sh
+19 −6 tests/test_library_builders.sh
+9 −2 travis_linux_steps.sh