Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

python3.8 wheels for osx, windows #63

Closed
mattip opened this issue Oct 8, 2019 · 8 comments
Closed

python3.8 wheels for osx, windows #63

mattip opened this issue Oct 8, 2019 · 8 comments

Comments

@mattip
Copy link
Contributor

mattip commented Oct 8, 2019

It seems we should be able to use multibuild to build osx wheels for python3.8 with the following diff. Multibuild supports 3.8 on OSX since matthew-brett/multibuild#262 (which is badly named)

diff --git a/.travis.yml b/.travis.yml
index 6b19a35..7eaae8d 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -63,6 +63,11 @@ matrix:
       env:
         - MB_PYTHON_VERSION=3.7
         - MB_PYTHON_OSX_VER=10.9
+    - os: osx
+      language: generic
+      env:
+        - MB_PYTHON_VERSION=3.8
+        - MB_PYTHON_OSX_VER=10.9
 
 before_install:
     - if [ "$TRAVIS_BRANCH" == "master" ]; then

@mattip mattip changed the title python3.8 wheels for osx python3.8 wheels for osx, windows Oct 8, 2019
@mattip
Copy link
Contributor Author

mattip commented Oct 8, 2019

multibuild now supports 3.80rc1 on windows as well, so this should work as well

diff --git a/.appveyor.yml b/.appveyor.yml
index 035fa86..d3611f6 100644
--- a/.appveyor.yml
+++ b/.appveyor.yml
@@ -50,6 +50,14 @@ environment:
       PYTHON_VERSION: 3.5
       PYTHON_ARCH: 64
 
+    - PYTHON: C:\Python38rc1
+      PYTHON_VERSION: 3.8
+      PYTHON_ARCH: 32
+
+    - PYTHON: C:\Python38rc1-x64
+      PYTHON_VERSION: 3.8
+      PYTHON_ARCH: 64
+
 init:
   - "ECHO %PYTHON% %PYTHON_VERSION% %PYTHON_ARCH%"
   - "ECHO \"%APPVEYOR_SCHEDULED_BUILD%\""

@charris
Copy link
Contributor

charris commented Oct 8, 2019

Should OS-X work also?

@mattip
Copy link
Contributor Author

mattip commented Oct 8, 2019

yup, both these diffs should be good to go

@charris
Copy link
Contributor

charris commented Oct 8, 2019

@charris
Copy link
Contributor

charris commented Oct 8, 2019

We will probably need @matthew-brett to shut down the stuck Windows build. We've seen this before :)

@matthew-brett
Copy link
Contributor

matthew-brett commented Oct 8, 2019 via email

@charris
Copy link
Contributor

charris commented Oct 8, 2019

Looks like it should be https://www.python.org/ftp/python/3.8.0/python-3.8.0rc1.exe

@stefanv
Copy link

stefanv commented Oct 15, 2019

I've opened a new issue for that here so that this discussion can be closed.

@charris charris closed this as completed Oct 15, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants