-
Notifications
You must be signed in to change notification settings - Fork 314
Cannot initialize project with poetry #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think we're especially tied to poetry (right @bemoody?). What would you recommend instead? |
Literally anything else. The easiest tool would be pip, but I'd recommend uv. |
I can submit a PR where you can see what will change. Not too much actually, but since it will follow established standards, users (devs) can use any standard-compliant tool. |
The wfdb-python package is designed to be usable with any Python application and certainly should work with any package manager. It currently relies on poetry's "build backend" (to generate the wheel file), but it should still be possible to install the package using pip or uv, and you shouldn't need to have poetry installed in order to use the package. I haven't had problems installing the package using pip. We may want to switch (back?) to using the (traditional, standard, some might say old-fashioned) setuptools build backend instead of poetry. We may also want to remove the references to poetry from the README.md, which may be confusing people. |
Please do, that would be quite helpful! |
@bemoody i have heard good things about uv, and using here would be a nice opportunity to give it a try. i assume i'll see you in the next hour or so, so can we have a quick chat before making a decision on which tool to use? |
You might want to read https://blog.ucodery.com//posts/the-trouble-with-poetry/. In my opinion a pretty accurate summary. |
@bemoody any build backend that follows the standard is fine, this is literally any tool except poetry (setuptools, but I prefer hatch). And yes, any package is usable, independent of how it was built. Like I said, I'll show you what I mean in a PR (but that could take me until tomorrow). |
@cbrnr if you have a chance to open a pull request, we would appreciate it (with whatever tooling you prefer). If not, I'll try to pick this up next week sometime. |
Fixes #501. To do: - [ ] Adapt workflow to setup access to PyPI (see https://docs.astral.sh/uv/guides/publish/#publishing-a-package) - [ ] Optimize tests (currently, I'm using `uv pip ...`, but I think this should be replaced with `uv run ...` - [ ] Bump any package versions and/or Python? - [ ] Use Ruff instead of Black?
Uh oh!
There was an error while loading. Please reload this page.
I just wanted to start developing, and after cloning the repo I did
poetry install
. After more than a minute, I received the following error(s):So the version range of pandas does not match the one from this project.
However, Poetry has several issues that make it a suboptimal choice for managing a Python project (the most serious is that is completely ignores standards agreed upon by the Python community). Therefore, would you be open to using a different tool that does support the official
pyproject.toml
specifications?The text was updated successfully, but these errors were encountered: