Skip to content

Stricter checking for CompletableContinuation state machine #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 20, 2018
Merged

Stricter checking for CompletableContinuation state machine #906

merged 1 commit into from
Dec 20, 2018

Conversation

elizarov
Copy link
Contributor

  • Always throw ISE on the second resume attempt
  • Always throw ISE on the second invokeOnCancellation attempt when cancelled
  • Moved error-throwing code into separate funs (slight optimization)

Fixes #901

@elizarov
Stricter checking for CompletableContinuation state machine
20cdc90 
* Always throw ISE on the second resume attempt
* Always throw ISE on the second invokeOnCancellation attempt when cancelled
* Moved error-throwing code into separate funs (slight optimization)

Fixes #901
@elizarov elizarov requested a review from qwwdfsad December 19, 2018 20:24
@qwwdfsad qwwdfsad merged commit 1d04e79 into develop Dec 20, 2018
@qwwdfsad qwwdfsad deleted the second-resume branch December 20, 2018 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qwwdfsad qwwdfsad qwwdfsad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elizarov @qwwdfsad