-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Debug agent to track alive coroutines #876
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
qwwdfsad
commented
Dec 6, 2018
- Can be installed dynamically or from command line
- Captures coroutine creation stacktrace and stores it in completion, automatically enhancing stacktrace recovery mechanism
- Allows to dump and introspect all active coroutines
- Allows to dump Job hierarchy
- When installed from command line, dumps all coroutines on kill -5
- Probe support in undispatched coroutines
qwwdfsad
commented
Dec 6, 2018
qwwdfsad
commented
Dec 7, 2018
core/kotlinx-coroutines-debug/src/debug/internal/DebugProbesImpl.kt
Outdated
Show resolved
Hide resolved
e9e8e45
to
0bae0a7
Compare
* Can be installed dynamically or from command line * Captures coroutine creation stacktrace and stores it in completion, automatically enhancing stacktrace recovery mechanism * Allows to dump and introspect all active coroutines * Allows to dump Job hierarchy * When installed from command line, dumps all coroutines on kill -5 * Probe support in undispatched coroutines
0bae0a7
to
c7239ac
Compare
elizarov
suggested changes
Dec 10, 2018
elizarov
reviewed
Dec 10, 2018
core/kotlinx-coroutines-debug/src/debug/internal/DebugProbesImpl.kt
Outdated
Show resolved
Hide resolved
core/kotlinx-coroutines-debug/src/debug/internal/DebugProbesImpl.kt
Outdated
Show resolved
Hide resolved
core/kotlinx-coroutines-debug/src/debug/internal/DebugProbesImpl.kt
Outdated
Show resolved
Hide resolved
core/kotlinx-coroutines-debug/src/debug/internal/DebugProbesImpl.kt
Outdated
Show resolved
Hide resolved
elizarov
reviewed
Dec 10, 2018
core/kotlinx-coroutines-debug/src/debug/internal/DebugProbesImpl.kt
Outdated
Show resolved
Hide resolved
52c149d
to
8e2428c
Compare
* Do not store creation stacktrace of the coroutine, recover it from ArtificialStackFrame * Reduce lock window where possible to avoid contention * Avoid stacktrace copying where possible
d0bbc7f
to
ea2bfe2
Compare
* Readme * Do not fail on Windows during signal handler installation * Do not warn about missing artificial stackframe
979abd5
to
d31c3f4
Compare
…endency of target process), use shadow plugin for that to avoid clashes with other byte-buddy versions and publish shadow jar instead of regular one for debug module
d31c3f4
to
3781a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.