Implement yield for unconfined dispatchers #750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
suggested changes
Oct 23, 2018
| @@ -21,26 +21,33 @@ internal object UndispatchedEventLoop { | |||
| @JvmField | |||
| internal val threadLocalEventLoop = CommonThreadLocal { EventLoop() } | |||
|
|
|||
| inline fun execute(continuation: DispatchedContinuation<*>, contState: Any?, mode: Int, block: () -> Unit) { | |||
| inline fun execute(continuation: DispatchedContinuation<*>, contState: Any?, mode: Int, doYield: Boolean = false, block: () -> Unit) : Boolean { | |||
There was a problem hiding this comment.
- Boolean result needs documentation on its meaning
- This line (with addition of doYield parameter) is too long.
| @@ -227,6 +234,12 @@ internal interface DispatchedTask<in T> : Runnable { | |||
| } | |||
| } | |||
|
|
|||
| internal fun DispatchedContinuation<Unit>.yield(): Boolean { | |||
There was a problem hiding this comment.
- Maybe rename to
yieldUndispatched& document the meaning of boolean result. In the context of this particular file this extension function is hard to understand. - Also refactor to idiomatic expression body, please, since this function does not do anything else but delegates to
UndispatchedEventLoop.executeand this intent should be immediately clear.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #737