[Obsolete] Add experimental AndroidX Lifecycle integration #655
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was version 1.0.0 instead of actual version 2.0.0
|
Adding a test dependency for |
SUPERCILEX
reviewed
Oct 4, 2018
This commit also adds eager cancellation in case it is needed.
gildor
reviewed
Oct 10, 2018
integration/kotlinx-coroutines-androidx-lifecycle/src/Lifecycle.kt
Outdated
Show resolved
Hide resolved
|
📢📢📢This PR is now ready for review! |
pakoito
reviewed
Oct 17, 2018
integration/kotlinx-coroutines-androidx-lifecycle/src/Lifecycle.kt
Outdated
Show resolved
Hide resolved
LouisCAD
changed the title
|
Closed in favor of #726 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This new integration provides a few extensions to make
Lifecycleplay well withJobandCoroutineScope.It has no documentation and tests at the moment, so don't merge it yet. Any contribution on this PR is welcome, especially regarding tests.EDIT: Ready for reviewThanks to @SUPERCILEX for the
aarconfiguration code for build.gradle.