-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Version 0.30.1 #646
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Version 0.30.1 #646
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Exceptions are never unwrapped when building cancellation cause * This leads to more consistent behavior with respect to 3rd-party exception that may be flowing through coroutines -- no 3rd-party stack-trace will even get accidentally lost. * This also leads to consistent behavior with respect to CancellationException: they are never handled (even if they have some real exception as cause). * The logic of how to cancel a child on failure (depending on the "handlesException" flag in the parent job) is now encapsulated into the parent itself, which leads to cleaner implementation in JobSupport. * Job.getCancellationException is not used for child cancellation anymore (it is used only and exclusively to cancel continuations) * ParentJob interface with ParentJob.getChildJobCancellationCause is introduced for parent job -> child job cancellation path.
* CRITICAL: Fixed synchronization of ThreadSafeHeap.removeFirstIf * Reworked code to make sure that memory for disposed task never leaks without violating ThreadSafeHeap encapsulation
* CoroutineScheduler close/shutdown sequence now guaranteed that a submitted task is either executed by the scheduler that is being concurrently shutdown or RejectedExecutionException is thrown. * RejectedExecutionException is caught by the coroutine dispatcher implementation and coroutines are rescheduled into DefaultExecutor if a (custom) instance of CoroutineScheduler is being shutdown. * Added stress test for coroutine scheduler closing.
* ThreadSafeHeap.addLastIf is inline to avoid closure allocation
* Main thread dispatchers are grouped under Dispatchers object and are discoverable via ServiceLoader * Dispatchers.Main can be consistently used and easily discovered, its implementation is discovered with ServiceLoader * It allows us to add iOS Dispatchers.Main implementation in the future thus opening the door for multiplatform UI-dispatched code * Workaround for #626, now Android users can start migration to RC coroutines Fixed #626
elizarov
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.