Coroutine scheduler is used by default instead of deprecated CommonPool #633
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
force-pushed
the
default-scheduler
branch
from
d1ab4df to
49b5020
Compare
* Documentation and guide are updated correspondingly * "DefaultDispatcher" is used as a public name of the default impl * Implementation is integrated with virtual time-source * Shutdown sequence is reimplemented in a safe way for tests, makes "close" safe to use on custom instances. * "close" on DefaultDispatcher throws exception just in case * -Dkotlinx.coroutines.scheduler=off can be used to switch back to CommonPool Fixes #198
elizarov
force-pushed
the
default-scheduler
branch
from
49b5020 to
5b490cc
Compare
qwwdfsad
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes "close" safe to use on custom instances.
CommonPool
Fixes #198