async and async-like builders cancel parent on failure #630
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elizarov
force-pushed
the
async
branch
2 times, most recently
from
f099444 to
5b18933
Compare
* Affects async, CompletableDeferred, and all Rx integration builders. * This makes all coroutine builders totally consistent. They all cancel parent on failure, but they all consider "CancellationException" to be the case of "normal cancellation" that does not propagate to parent. The only missing case is Job() that should be fixed together with introduction of SupervisorJob(). * Note that "scoping" builders don't "cancel the parent", but rethrow the corresponding exception instead, so it that is how it gets propagated up the stack. * This makes parallel decomposition exception-safe. You cannot loose an exception as along as default (child async) behavior is not overridden. Fixes #552
qwwdfsad
approved these changes
Sep 28, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cancel parent on failure, but they all consider "CancellationException"
to be the case of "normal cancellation" that does not propagate to
parent. The only missing case is Job() that should be fixed together
with introduction of SupervisorJob().
the corresponding exception instead, so it that is how it gets
propagated up the stack.
cannot loose an exception as along as default (child async)
behavior is not overridden.
Fixes #552