Provide suspendAtomicCancellableCoroutineReusable primitive, high-per… #596
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Uses Kotlin version 1.3-M2 * Uses Kotlin/Native version 0.9
* Replace SuccessOrFailure with Result * Replace buildSequence and buildIterator with sequence and iterator * Apply @BuilderInference on all builders (including extension methods to workaround inference bug)
…formance intrinsic which allows to reuse cancellation machinery and opens the way to garbage-free channels: * Make AbstractContinuation reusable * Add additional field to DispatchedContinuation to cache cancellable continuation * Use suspendAtomicCancellableCoroutineReusable in channels (+15% of performance on ping-pong) * Detect calls to tryResume and forbid cancellation reusing in order to make channels work with selects * Fix benchmarks on 1.3 Fixes #534
|
Crazy idea: get rid of
|
… CoroutineDispatcher
* Extracted getOrCreateCancellableContinuation from suspendAtomicCancellableCoroutineReusable * Separate NON_REUSABLE constant for readability * Make non-reusable only on idempotent tryResume
elizarov
force-pushed
the
eap13
branch
4 times, most recently
from
9a415e0 to
d3ac541
Compare
qwwdfsad
force-pushed
the
eap13
branch
4 times, most recently
from
00dad2d to
0950dfa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…formance intrinsic which allows to reuse cancellation machinery and opens the way to garbage-free channels:
Fixes #534