Restore Android compatibility in Executor.asCoroutineDispatcher
#4396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dkhalanskyjb
commented
Mar 26, 2025
•
dkhalanskyjb
commented
- Upgrade Gradle to 8.13
- Fix animalsniffer checks
- Restore a trick removed in Remove various obsolete code #4196
- Clean up some warnings in the build script
qwwdfsad
approved these changes
Apr 2, 2025
| @@ -18,3 +21,20 @@ internal actual annotation class BenignDataRace() | |||
| @Suppress("NOTHING_TO_INLINE") // So that R8 can completely remove ConcurrentKt class | |||
| internal actual inline fun <E> identitySet(expectedSize: Int): MutableSet<E> = | |||
| Collections.newSetFromMap(IdentityHashMap(expectedSize)) | |||
|
|
|||
| private val REMOVE_FUTURE_ON_CANCEL: Method? = try { | |||
There was a problem hiding this comment.
Should we drop a comment that it's for Android 21+ compatibility?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.