Skip to content

Improve performance of SharingStarted.StartedLazily by changing flow to unsafeFlow #4393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Improve performance of SharingStarted.StartedLazily by changing flow to unsafeFlow #4393

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion kotlinx-coroutines-core/common/src/flow/SharingStarted.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
package kotlinx.coroutines.flow

import kotlinx.coroutines.*
import kotlinx.coroutines.flow.internal.unsafeFlow
import kotlinx.coroutines.internal.IgnoreJreRequirement
import kotlin.time.*

Expand Down Expand Up @@ -146,7 +147,7 @@ private class StartedEagerly : SharingStarted {
}

private class StartedLazily : SharingStarted {
override fun command(subscriptionCount: StateFlow<Int>): Flow<SharingCommand> = flow {
override fun command(subscriptionCount: StateFlow<Int>): Flow<SharingCommand> = unsafeFlow {
var started = false
subscriptionCount.collect { count ->
if (count > 0 && !started) {
Expand Down