Skip to content

Enable '-jvm-default=disable' explicitly to prevent API dump changes #4361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 4, 2025

Conversation

udalov
Copy link
Member

@udalov udalov commented Feb 21, 2025

The default mode is changing from 'disable' to 'enable' in KT-71768. However, core libraries will migrate to the new '-jvm-default=enable' mode explicitly, once they update to Kotlin 2.2, see KT-72051.

The default mode is changing from 'disable' to 'enable' in KT-71768.
However, core libraries will migrate to the new '-jvm-default=enable'
mode explicitly, once they update to Kotlin 2.2, see KT-72051.
@udalov
Copy link
Member Author

udalov commented Mar 3, 2025

@dkhalanskyjb Please approve so that I can merge it together with the MR in Kotlin.

Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is just a formality, sure. If not, I don't understand why not just introduce API dump changes, given that they look benign.

@udalov
Copy link
Member Author

udalov commented Mar 4, 2025

Sure, I just thought that keeping the kotlin-community/k2/dev branch as close to develop as possible is convenient.

When the time comes to update the compiler dependency in the libraries to 2.2, you will either need to update API dumps (preferably), or enable -jvm-default=disable in the same way (in case there are any problems).

@udalov udalov merged commit c907947 into kotlin-community/k2/dev Mar 4, 2025
1 check failed
@udalov udalov deleted the udalov branch March 4, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants