Skip to content

Update to Dokka 2.0.0 #4349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 9, 2025
Merged

Update to Dokka 2.0.0 #4349

merged 1 commit into from
Apr 9, 2025

Conversation

whyoleg
Copy link
Contributor

@whyoleg whyoleg commented Feb 12, 2025

No description provided.

@whyoleg whyoleg self-assigned this Feb 12, 2025
@whyoleg whyoleg mentioned this pull request Feb 12, 2025
Closed
@whyoleg whyoleg marked this pull request as draft February 12, 2025 11:27
@berezinant berezinant mentioned this pull request Feb 13, 2025
Closed
@berezinant berezinant mentioned this pull request Feb 25, 2025
Merged
@zoobestik zoobestik force-pushed the whyoleg/dokka2-sync branch from b6534d6 to 5aa0c22 Compare April 8, 2025 12:16
@whyoleg whyoleg changed the title [DONT MERGE] Update to Dokka 2.0.0 Update to Dokka 2.0.0 Apr 9, 2025
@whyoleg whyoleg requested a review from dkhalanskyjb April 9, 2025 09:59
@whyoleg whyoleg marked this pull request as ready for review April 9, 2025 09:59
@whyoleg
Copy link
Contributor Author

whyoleg commented Apr 9, 2025

(please don't delete whyoleg/dokka2-sync branch for some time until we finalize deployment changes)

dkhalanskyjb
dkhalanskyjb reviewed Apr 9, 2025
View reviewed changes
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What exactly should I look at? Should I look at Dokka's output to see that nothing broke, or is my approval just a formality?

@whyoleg
Copy link
Contributor Author

whyoleg commented Apr 9, 2025

Should I look at Dokka's output to see that nothing broke, or is my approval just a formality?

Overall, just a formality, as we already deployed it to kotlinlang.
Also, when I was preparing the PR I've checked that there were no real changes except for styles changes (which were expected)

@whyoleg whyoleg merged commit adc1ca5 into master Apr 9, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees

@whyoleg whyoleg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@whyoleg @dkhalanskyjb