Skip to content

Redispatch local tasks before thread parking in runBlocking #4312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions kotlinx-coroutines-core/jvm/src/Builders.kt
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,8 @@

package kotlinx.coroutines

import kotlinx.coroutines.scheduling.*
import kotlinx.coroutines.scheduling.CoroutineScheduler
import java.util.concurrent.locks.*
import kotlin.contracts.*
import kotlin.coroutines.*
Expand Down Expand Up @@ -95,6 +97,12 @@ private class BlockingCoroutine<T>(
val parkNanos = eventLoop?.processNextEvent() ?: Long.MAX_VALUE
// note: process next even may loose unpark flag, so check if completed before parking
if (isCompleted) break
if (blockedThread is CoroutineScheduler.Worker) {
val queue = blockedThread.localQueue
while (queue.size > 0) {
queue.poll()?.let { blockedThread.scheduler.dispatch(it) }
}
}
parkNanos(this, parkNanos)
}
} finally { // paranoia
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
package kotlinx.coroutines

import java.util.concurrent.*
import kotlin.coroutines.*
import kotlin.coroutines.intrinsics.*
import kotlin.test.*

class RunBlockingDispatchLocalTasksTest {

// A coroutine deadlock occurs if there is a task in the local queue
// of the blocking thread before it is parked by the nested runBlocking
@Test(timeout = 1000)
fun testEmptyLocalTasksBeforePark() {
runBlocking(Dispatchers.IO) {
val latch = CountDownLatch(1)
lateinit var launchContinuation: Continuation<Unit>
lateinit var runBlockingContinuation: Continuation<Unit>
CoroutineScope(Dispatchers.IO).launch {
suspendCoroutineUninterceptedOrReturn {
launchContinuation = it
latch.countDown()
COROUTINE_SUSPENDED
}
yield()
runBlockingContinuation.resume(Unit)
}
latch.await()
runBlocking {
suspendCancellableCoroutine {
runBlockingContinuation = it
launchContinuation.resume(Unit)
}
}
}
}
}