Update to Kotlin 2.0-RC3 #4129
Update to Kotlin 2.0-RC3 #4129
Conversation
Apply all workarounds from k2 branch
|
If I'm stuck on the 1.9 line, will I be able to consume the new artifacts? |
| @@ -0,0 +1,19 @@ | |||
| package kotlinx.coroutines.test.internal | |||
|
|
|||
| /* This is a declaration of JS's `Promise<Unit>`. We need to keep it a separate class, because | |||
There was a problem hiding this comment.
Worth linking to https://youtrack.jetbrains.com/issue/KT-60561 ?
I just hope it gets fixed soon tbh, this workaround means everyone is going to have their own promise types, a mess.
There was a problem hiding this comment.
Huh? Is everyone really creating their own Promise types? The TestResult class has a very specific and technical purpose: to let Kotlin know that it should handle the values returned from @Test fun on JS in a specific manner. Do many other codebases maintain their own test frameworks instead of using kotlinx-coroutines-test?
There was a problem hiding this comment.
Well it's not really just for testing. I have some typealiases to Promise<T> in my KMP project and I can work with them in K1. In K2 I have to remove the typealias or have to create an intermediate class, just like JsPromiseInterfaceForTesting.
There was a problem hiding this comment.
typealias Future<T> = Promise<T> should still work. Is your use case covered by it?
There was a problem hiding this comment.
It works because you have the type parameter in Future, but something like typealias HostValue = Promise<Int> won't work. This plus KT-61043 makes working with typealiases a lot more cumbersome.
Apply all workarounds from k2 branch