Update the copyright notices to the new requirements #4016
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
dkhalanskyjb
commented
Jan 18, 2024
dkhalanskyjb
commented
- Remove copyright notices from individual files;
- Update the NOTICE file to include the year of initial publication and the year of the latest change;
- Remove the IDEA template for adding notices to every file.
* Remove copyright notices from individual files; * Update the NOTICE file to include the year of initial publication and the year of the latest change; * Remove the IDEA template for adding notices to every file.
JakeWharton
reviewed
Jan 18, 2024
LICENSE.txt
Outdated
| Copyright 2000-2020 JetBrains s.r.o. and Kotlin Programming Language contributors. | ||
| Copyright 2016-2024 JetBrains s.r.o. and Kotlin Programming Language contributors. |
There was a problem hiding this comment.
This file should not be modified from its original source. This is the part of the license that provides the template for you to apply somewhere else in the project.
From the paragraph above:
attach the following boilerplate notice, with the fields enclosed by brackets "[]" replaced with your own identifying information
This "attach" is usually done in the README or a NOTICE file with the years and copyright holder substituted in, but this line in this file should still contain the original template.
There was a problem hiding this comment.
I thought it was okay to edit the part of LICENSE after "END OF TERMS AND CONDITIONS", but since we do have NOTICE, I guess there's no reason to do so.
We check a classfile to match verbatim to make sure it doesn't change unexpectedly, and removing the copyright triggered the check, as the line numbers of the functions (which are compiled into the classfile) changed.
qwwdfsad
approved these changes
Jan 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.