Skip to content

Suppress forgotten error about actual classifier scope mismatch #3891

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

dsavvinov
Copy link
Contributor

Code red in IDE on IU-232.9921.47, Kotlin IDE Plugin 232-1.9.20-Beta-release-242

Would be nice to merge it, because IDE Integration tests in IJ check exactly this file and they're failing at the moment.

@qwwdfsad
Copy link
Collaborator

@nikitabobko could you please take a look? I'm surprised the build passes (e.g. the code compiles with -Werror) while IDE fails and want to double check here

@nikitabobko
Copy link
Member

The first thing to notice: you can see that the same warning is already suppressed in the supermethod actual LockFreeLinkedListNode.nextIfRemoved.

Different results in IDE and compiler happen because when we analyze common code, the K1 compiler sees platform declarations as well, but the K1 IDE doesn't see platform declarations. And when we compare member scopes you get one result or another, because of that.

In K2, we will fix that, because IDE and compiler will be consistent. They both won't see platform declarations during common code analysis.

I suggest accepting Dima's PR because it suppresses the error that will happen in K2.

@nikitabobko
Copy link
Member

nikitabobko commented Sep 19, 2023

I suggest accepting Dima's PR because it suppresses the error that will happen in K2.

Or if it's not the blocker for IDE tests (Do IDE tests have a copy of this file, or do they clone this git repo?) then we can reject this PR until we really need it for K2

@qwwdfsad qwwdfsad merged commit 84a2cba into develop Sep 19, 2023
@qwwdfsad qwwdfsad deleted the dsavvinov/fix-actual-classifier-scope-mismatch-leftover branch September 19, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants