Mark BufferedChannelIterator.continuation @BeningDataRace to address … #3873
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…potential UB and OoTA on K/N Fixes #3834
dkhalanskyjb
approved these changes
Oct 11, 2023
| @@ -1583,6 +1583,7 @@ internal open class BufferedChannel<E>( | |||
| * continuation. The [tryResumeHasNext] and [tryResumeHasNextOnClosedChannel] | |||
| * function resume this continuation when the [hasNext] invocation should complete. | |||
| */ | |||
| @BenignDataRace // See its uses for the explanation of the race | |||
There was a problem hiding this comment.
I think we should explicitly list the races right next to the annotation. This way, if a new race is discovered, we won't look at the annotation and go, "oh yeah, we know about this race, it's benign, no worries."
| */ | ||
| @BenignDataRace |
There was a problem hiding this comment.
I like the explanation here, for example.
dkhalanskyjb
approved these changes
Oct 23, 2023
igoriakovlev
pushed a commit
that referenced
this pull request
Nov 2, 2023
* Mark BufferedChannelIterator.continuation as @BeningDataRace to address potential UB and OoTA on K/N * Explain benign data-race on SelectImplementation.clauses and mark it with @BenignDataRace * Explain benign data-race on SelectImplementation.internalResult and mark it with @BenignDataRace Fixes #3834 Fixes #3843
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…potential UB and OoTA on K/N
Fixes #3834