Skip to content

Conditionally remove native targets that are removed in 1.9.20 #3825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 28, 2023

Conversation

mvicsokolova
Copy link
Contributor

@mvicsokolova mvicsokolova commented Jul 25, 2023

This commit conditionally removes iosArm32, watchosX86 that are removed in 1.9.20.

This commit is necessary for the aggregate builds.

A similar commit was added earlier to atomicfu: Kotlin/kotlinx-atomicfu@7697fff

@mvicsokolova mvicsokolova requested a review from qwwdfsad July 25, 2023 13:16
@mshishkina mshishkina added the kotlin-merge-blocker PRs labeled as merge-blockers are effectively preventing a corresponding merge into main Kotlin repo label Jul 27, 2023
@mshishkina mshishkina self-requested a review July 27, 2023 11:34
This reverts commit 6d1270c.
@qwwdfsad qwwdfsad merged commit e0dd277 into develop Jul 28, 2023
@qwwdfsad qwwdfsad deleted the remove-deprecated-native-targets branch July 28, 2023 12:47
@mshishkina
Copy link

Commit is merged into kotlin-community/dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kotlin-merge-blocker PRs labeled as merge-blockers are effectively preventing a corresponding merge into main Kotlin repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants