Third time's the charm #3753
Merged
Third time's the charm #3753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, this isn't required. If we look at the sources of how this is used in the problematic library, the dispatch timeout is not used at all, |
qwwdfsad
approved these changes
May 12, 2023
ephemient
reviewed
May 12, 2023
| @@ -580,6 +580,6 @@ internal expect fun dumpCoroutines() | |||
| public fun TestScope.runTestLegacy( | |||
| dispatchTimeoutMs: Long, | |||
| testBody: suspend TestScope.() -> Unit, | |||
| unused1: Int, | |||
| marker: Int, | |||
| unused2: Any?, | |||
There was a problem hiding this comment.
Maybe rename the parameters to mask: Int, marker: Any?.
There was a problem hiding this comment.
Ah, I'm too slow. Well it shouldn't really matter.
There was a problem hiding this comment.
I disagree. unused2 lends this function some tongue-in-a-cheek charm, which it deserves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3673
Thanks, @ephemient!
Context: #3742 (comment)