Skip to content

KT-51515 cleanup #3649

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2023
Merged

KT-51515 cleanup #3649

merged 3 commits into from
Apr 17, 2023

Conversation

elizarov
Copy link
Contributor

@elizarov elizarov commented Feb 28, 2023 •
edited
Loading

See https://youtrack.jetbrains.com/issue/KT-51515
Small fixes to clean up #3631

  • Fix comment about 100k corouties in cancellation and timeouts section (it is now 10k!)
  • Make "Coroutines are light-weight" example runnable by reducing the number of coroutines to 50k, also change the wording about what happens with threads

@elizarov
Fix comment about 100k corouties in cancellation and timeouts section
ab883a2 
Changed to 10K consistently with the code.
@elizarov
Make "Coroutines are light-weight" example runnable
4e32bd2 
Reduce the number of coroutines to 50K - works on playground.
Also change the working about what happens with threads.
@dkhalanskyjb dkhalanskyjb mentioned this pull request Feb 28, 2023
Closed
@danil-pavlov danil-pavlov requested review from danil-pavlov and removed request for koshachy March 7, 2023 12:51
danil-pavlov
danil-pavlov requested changes Mar 7, 2023
View reviewed changes
Copy link
Contributor

@danil-pavlov danil-pavlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest not making it a note because in this case, you'll get two notes one after another and visually overload the text

@qwwdfsad qwwdfsad merged commit 2653cd2 into master Apr 17, 2023
@qwwdfsad qwwdfsad deleted the KT-51515-cleanup branch April 17, 2023 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

@danil-pavlov danil-pavlov danil-pavlov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@elizarov @dkhalanskyjb @danil-pavlov @qwwdfsad