Skip to content

Workaround for debugger+compiler crash: #3625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 14, 2023
Merged

Workaround for debugger+compiler crash: #3625

merged 1 commit into from
Feb 14, 2023

Conversation

qwwdfsad
Copy link
Member

  • 'inline' modifier is removed from 'findSegmentInternal'. It previously lead to KT-55983: incorrect SMAP was produced that crashed the debugger consistently
  • Non-inline functions are non-capturing, thus no additional performance overhead
  • Method-reference is extracted to a variable in few places as it were crashing JVM compiler with AIOOB consistently

@qwwdfsad
Workaround for debugger+compiler crash:
8dcb98d 
* 'inline' modifier is removed from 'findSegmentInternal'. It previously lead to KT-55983: incorrect SMAP was produced that crashed the debugger consistently
* Non-inline functions are non-capturing, thus no additional performance overhead
* Method-reference is extracted to a variable in few places as it were crashing JVM compiler with AIOOB consistently
@qwwdfsad qwwdfsad requested a review from ndkoval February 13, 2023 17:44
@qwwdfsad qwwdfsad merged commit f538af6 into develop Feb 14, 2023
@qwwdfsad qwwdfsad deleted the fix-atomic-inlines branch February 14, 2023 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ndkoval ndkoval ndkoval approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @ndkoval