Skip to content

Remove dead-code in the LockFreeLinkedList implementation after new c… #3624

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 14, 2023
Merged

Remove dead-code in the LockFreeLinkedList implementation after new c… #3624

merged 2 commits into from
Feb 14, 2023

Conversation

qwwdfsad
Copy link
Member

…hannels implementation

  • Slightly speedup the build without unnecessary stress-tests
  • Get rid of dead-code that was used only by channels, so it's easier to reason about JobSupport implementation
  • Slightly cut dex size in the face of new channels regression as LFLL is no longer shared between JobSupport and Channel

@qwwdfsad
Remove dead-code in the LockFreeLinkedList implementation after new c…
3c32d24 
…hannels implementation

* Slightly speedup the build without unnecessary stress-tests
* Get rid of dead-code that was used only by channels, so it's easier to reason about JobSupport implementation
* Slightly cut dex size in the face of new channels regression as LFLL is no longer shared between JobSupport and Channel
@qwwdfsad
Copy link
Member Author

I've deliberately avoided adjusting the comments to LFLL as it's doomed to be removed and definitely won't be modified

@qwwdfsad qwwdfsad merged commit fc6c811 into develop Feb 14, 2023
@qwwdfsad qwwdfsad deleted the cleanup-dex-size branch February 14, 2023 13:29
ndkoval pushed a commit that referenced this pull request Feb 14, 2023
@qwwdfsad @ndkoval
Remove dead-code in the LockFreeLinkedList implementation after new c… (
a21b17d 
#3624)

* Remove dead-code in the LockFreeLinkedList implementation after new channels implementation

* Slightly speedup the build without unnecessary stress-tests
* Get rid of dead-code that was used only by channels, so it's easier to reason about JobSupport implementation
* Slightly cut dex size in the face of new channels regression as LFLL is no longer shared between JobSupport and Channel
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @dkhalanskyjb