Channel fixes #362
Closed
Channel fixes #362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
commented
May 30, 2018
| return true | ||
| } | ||
|
|
||
| private fun helpClose(closed: Closed<*>) { |
There was a problem hiding this comment.
Discuss: helpClose should probably try to cancel job as well, so it will be linearizable along with channel
There was a problem hiding this comment.
Given the current implementation doesn't try to cancel the job, could this lead to a deadlock if somehow, a runBlocking { ... } call is waiting for it because it'd be waiting for the job to complete?
There was a problem hiding this comment.
The current implementation doesn't have a job, this branch is not going to master.
LouisCAD
reviewed
Jul 17, 2018
| override fun toString(): String = "ArrayChannel(1)" | ||
| }, | ||
| ARRAY_10 { | ||
| override fun create(): Channel<Int> = ArrayChannel(8) | ||
| override fun create(job: Job): Channel<Int> = ArrayChannel(8, job) |
There was a problem hiding this comment.
ARRAY_10 with a size of 8??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channel
closelinearizabilityonClosemethodFixes for #359 and #260