Fix example code #3582
Merged
Fix example code #3582
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GlobalScope should not be in loadContributorsConcurrent if you want the function to be cancellable by using the cancel button.
|
@danil-pavlov PTAL, it seems like the guide have this mixed up |
|
@svtk, could you take a look, please? Maybe we need to update the solution in the example project as well |
|
@danil-pavlov The solution and the previous version are correct. It seems to be introduced when we moved the text to the docs. @isaialvarado Thanks for pointing it out! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GlobalScope should not be in loadContributorsConcurrent if you want the function to be cancellable by using the cancel button.