Skip to content

Remove confusing comma in Coroutines Hands-on #3581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

SebastianAigner
Copy link
Member

This change makes sure the sentence reflects the actual meaning: We're switching to the type of API that uses callbacks, rather than switching to the API, which incidentally happens to use callbacks.

@dkhalanskyjb
Copy link
Collaborator

I don't understand it. The sentence is about switching to a particular API, called Retrofit, which mitigates the problem by using callbacks instead of blocking. Am I missing something?

@SebastianAigner
Copy link
Member Author

It's precisely not about switching to an API called Retrofit. The previous example also uses the Retrofit API. This sentence specifically talks about the part of the Retrofit API that happens to use callbacks.

In other words, we're switching "[from the blocking Retrofit API] to the callback-based Retrofit API".

@dkhalanskyjb
Copy link
Collaborator

Ah, yes, you're right! Sorry for the noise.

@dkhalanskyjb dkhalanskyjb merged commit dea2ca5 into master Jan 9, 2023
@SebastianAigner SebastianAigner deleted the SebastianAigner-patch-1 branch January 10, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants