Skip to content

Do not propagate exceptions to CoroutineExceptionHandler in 'future' … #3580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 16, 2023

Conversation

qwwdfsad
Copy link
Member

@qwwdfsad qwwdfsad commented Jan 6, 2023

…builder if it has been cancelled in order to be consistent with other future implementations

Fixes #3452

@qwwdfsad qwwdfsad requested a review from dkhalanskyjb January 6, 2023 16:12
@qwwdfsad
Copy link
Member Author

qwwdfsad commented Jan 6, 2023

I've also checked the implementation of jdk HTTP client -- they indeed do the same and ignore false returned from completeExceptionally during any exceptional code-path

…builder if it has been cancelled in order to be consistent with other future implementations

Fixes #3452
@qwwdfsad qwwdfsad force-pushed the cf-exception-report branch from 966a56e to e741659 Compare January 6, 2023 16:13
@qwwdfsad qwwdfsad merged commit 71125e3 into develop Jan 16, 2023
@qwwdfsad qwwdfsad deleted the cf-exception-report branch January 16, 2023 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants