Preliminary prototype of #3439 #3572
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It solves two problems: * Stealing into exclusively owned local queue does no longer require and CAS'es or atomic operations where they were previously not needed. It should save a few cycles on the stealing code path * The overall timing perturbations should be slightly better now: previously it was possible for the stolen task to be immediately got stolen again from the stealer thread because it was actually published to owner's queue, but its submission time was never updated Fixes #3416
…the overall code structure
Previously, a worker thread unconditionally processed tasks from its own local queue, even if tasks were CPU-intensive, but CPU token was not acquired. Fixes #3418
Previously, a worker thread unconditionally processed tasks from its own local queue, even if tasks were CPU-intensive, but CPU token was not acquired. Fixes #3418
Co-authored-by: Dmitry Khalanskiy <[email protected]>
Co-authored-by: Dmitry Khalanskiy <[email protected]>
| public fun Thread.isIoDispatcherThread(): Boolean { | ||
| if (this !is CoroutineScheduler.Worker) return false | ||
| return isIo() | ||
| } |
There was a problem hiding this comment.
Looks very similar to the functions at the bottom of CoroutineScheduler.kt and would probably enjoy their company.
There was a problem hiding this comment.
I've put it here solely because processNextEventInCurrentThread and I wanted to keep these "internal event loop spinners" in a single place to keep track of
| val task = tryExtractBlockingTask(--end) | ||
| // CPU or (BLOCKING & hasBlocking) | ||
| val shouldProceed = !onlyBlocking || blockingTasksInBuffer.value > 0 | ||
| while (start != end && shouldProceed) { |
There was a problem hiding this comment.
shouldProceed doesn't update. It doesn't feel like it's intentional, but if it is, it can be moved to an if wrapping the while.
# Conflicts: # kotlinx-coroutines-core/jvm/src/scheduling/CoroutineScheduler.kt # kotlinx-coroutines-core/jvm/src/scheduling/WorkQueue.kt
qwwdfsad
force-pushed
the
scheduler-internal-api
branch
from
9554c01 to
4a6a0f3
Compare
|
Closing in the favor of #3641 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.