Skip to content

Prepare coroutines for including to the community projects composite build #3559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2022

Conversation

stasjas
Copy link
Contributor

@stasjas stasjas commented Dec 21, 2022

//KTI-1051

Support passing an url for a kotlin compiler repository, drop space kotlin/dev repo from dependencies: Kotlin compiler artifacts should be downloaded from maven central by default. In case of compiling with not-published into the MC kotlin compiler artifacts, a kotlin_repo_url should be specified as a gradle parameter(E.g. space kotlin/dev repo).

@stasjas stasjas requested a review from dkhalanskyjb December 21, 2022 16:26
…cts composite build //KTI-1051

Support passing an url for a kotlin compiler repository, drop space kotlin/dev repo from dependencies:
Kotlin compiler artifacts should be downloaded from maven central by default.
In case of compiling with not-published into the MC kotlin compiler artifacts, a kotlin_repo_url should be specified as a gradle parameter(E.g. space kotlin/dev repo).
@stasjas stasjas force-pushed the kotlin-community/dev branch from 5702731 to 28d98e8 Compare December 27, 2022 11:44
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is this ready for merging, or is there something more to do?

@stasjas
Copy link
Contributor Author

stasjas commented Dec 28, 2022

Thats final version for now. So can be merged

@stasjas stasjas merged commit 8eb8e68 into develop Dec 28, 2022
@dkhalanskyjb dkhalanskyjb deleted the kotlin-community/dev branch December 28, 2022 11:43
@dkhalanskyjb dkhalanskyjb restored the kotlin-community/dev branch December 28, 2022 11:43
@qwwdfsad qwwdfsad deleted the kotlin-community/dev branch December 28, 2022 15:31
@qwwdfsad qwwdfsad restored the kotlin-community/dev branch January 2, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants