Skip to content

Docs: add about -Xdebug to disable "was optimise out" #3553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

PetrakovichVictoria
Copy link
Contributor

KT-54548 [Docs] Coroutine debugger: disable "was optimised out" compiler feature

Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this tip would be much better formulated if it was preceded by its context. For example, "sometimes, in the debugger, you can see optimized out next to a variable name (see the picture) [an accompanying picture]; when debugging, this is often undesired," etc. As is, it comes out of nowhere.

@PetrakovichVictoria
Copy link
Contributor Author

PetrakovichVictoria commented Dec 26, 2022

@dkhalanskyjb, thanks for your previous review. Rereview, please.

@PetrakovichVictoria PetrakovichVictoria changed the title Docs: add tip about -Xdebug to disable "was optimise out" feature Docs: add about -Xdebug to disable "was optimise out" Dec 27, 2022
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, you addressed every concern neatly!

Is there a reason why this was moved to coroutines-basics.md though? I think coroutines-basics.md is a tooling-agnostic introduction, one that everyone could follow even on https://play.kotlinlang.org/. Maybe debugging.md would be a better place.

@PetrakovichVictoria
Copy link
Contributor Author

PetrakovichVictoria commented Dec 27, 2022

Is there a reason why this was moved to coroutines-basics.md though?

@dkhalanskyjb, yes, because I understood that those pages where this information was before are tutorials with specific code which doesn't contain suspend fun syntax.
So, I moved this section to the first mention of suspend functions.

Maybe debugging.md would be a better place.

I agree, but this page is hidden from the TOC now, and as I know this was made consciously, I'll write you in DM.

Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aside from this, I think it's good to go!

@PetrakovichVictoria PetrakovichVictoria merged commit 35c6be1 into master Dec 28, 2022
@PetrakovichVictoria PetrakovichVictoria deleted the new-compiler-option-for-disabling-optimizations branch December 28, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants