-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Docs: add about -Xdebug to disable "was optimise out" #3553
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: add about -Xdebug to disable "was optimise out" #3553
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this tip would be much better formulated if it was preceded by its context. For example, "sometimes, in the debugger, you can see optimized out
next to a variable name (see the picture) [an accompanying picture]; when debugging, this is often undesired," etc. As is, it comes out of nowhere.
@dkhalanskyjb, thanks for your previous review. Rereview, please. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, you addressed every concern neatly!
Is there a reason why this was moved to coroutines-basics.md
though? I think coroutines-basics.md
is a tooling-agnostic introduction, one that everyone could follow even on https://play.kotlinlang.org/. Maybe debugging.md
would be a better place.
@dkhalanskyjb, yes, because I understood that those pages where this information was before are tutorials with specific code which doesn't contain
I agree, but this page is hidden from the TOC now, and as I know this was made consciously, I'll write you in DM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aside from this, I think it's good to go!
KT-54548 [Docs] Coroutine debugger: disable "was optimised out" compiler feature