Remove some broken tests #3513
Merged
Remove some broken tests #3513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests haven't been reliable for a very long time for some reason. We could ensure them passing by a manual check, but it feels like nobody actually relies on this behavior, and it's not clear who even would want to. https://github.com/search?p=3&q=%22dispatchTimeoutMs+%3D+0%22&type=Code https://grep.app/search?q=dispatchTimeoutMs%20%3D%200
qwwdfsad
approved these changes
Oct 31, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tests haven't been reliable for a very long time for some reason. We could ensure that they pass with a manual check, but it feels like nobody actually relies on this behavior, and it's not clear who even would want to.
https://github.com/search?p=3&q=%22dispatchTimeoutMs+%3D+0%22&type=Code https://grep.app/search?q=dispatchTimeoutMs%20%3D%200