suggested update to SharedFlow.kt #3497
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coroutines and Flows are amazing I love them and many many thanks for them 🤩🤩🤩🤩 You guys in JetBrains rock 🤘🤘🤘 🚀🚀🚀 I have a small suggestion: According to this big discussion: Kotlin#2387 and a lot of confusion, including myself, default value of `extraBufferCapacity` should be 1 instead of 0 and I think this parameter also needs better explanation
|
Thanks! Unfortunately, we cannot accept this contribution -- it is a breaking change for stable API that will break almost every client of |
|
At least we can update docs, cause |
|
Yes, it probably makes sense |
|
So should I send another pull request with just doc changes? @qwwdfsad |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coroutines and Flows are amazing I love them and many many thanks for them 🤩🤩🤩🤩 You guys in JetBrains rock 🤘🤘🤘 🚀🚀🚀
I have a small suggestion:
According to this big discussion:
#2387 and a lot of confusion, including myself, default value of
extraBufferCapacityshould be 1 instead of 0 and I think this parameter also needs better explanation