Fix atomicfu plugin application

[mvicsokolova]

The new way of atomicfu compiler plugin applicaition takes 3 steps:

• first the compiler plugin AtomicfuKotlinGradleSubplugin is applied. It adds an extension AtomicfuKotlinGradleExtension with properties for turning on jvm and js transformation.
• Then these extension properties are set in the AtomicfuGradlePlugin.
• When AtomicfuKotlinGradleSubplugin$isApplicable is invoked, the values of the extension properties are already set and the plugin is applied accordingly.

When we apply the atomicfu plugin too late in the configuration -- the AtomicfuKotlinGradleSubplugin$isApplicable may be called earlier, when the properties are not set yet and the compiler plugin is not applied.

The Train build with these changes + atomicfu JVM compiler plugin support

[mvicsokolova]

@Tapchicoma could you please have a look at this issue, because I do not quite get the reason

[Tapchicoma]

The problem is in this line.

It triggers :kotlinx-core-coroutines project evaluation including all afterEvaluate { .. } closures, where subplugin options are configured. The problem is that apply plugin: "configure-compilation-conventions" goes after this line meaning it configures almost nothing in :kotlinx-core-coroutines subproject as it is already evaluated. By moving "configure-compilaiton-conventions" above line #139, conventions are applied before core project evaluation fixing the issue.

[qwwdfsad]

I'm okay with this particular kludge.

What puzzles me is the general debuggability, i.e. consider the same situation happens to an external user:

When we apply the atomicfu plugin too late in the configuration -- the AtomicfuKotlinGradleSubplugin$isApplicable may be called earlier, when the properties are not set yet and the compiler plugin is not applied.

What are the option for them to debug it and understand what's going on? Are there better options?

[Tapchicoma]

imho this case is nothing to do with Atomicfu plugin as it is not even present when core project evaluates. This is more Gradle edge-case. BTW why do you need evaluationDependsOn for core project? 🤔