Skip to content

Update integration/README.md #3485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 19, 2022
Merged

Update integration/README.md #3485

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ddfd727
Update integration/README.md
dkhalanskyjb Oct 17, 2022
8b59d17
Remove the instructions for contributing new integrations
dkhalanskyjb Oct 18, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 8 additions & 10 deletions integration/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Coroutines integration

This directory contains modules that provide integration with various asynchronous callback- and future-based libraries.
Module name below corresponds to the artifact name in Maven/Gradle.
Module names below correspond to the artifact names in Maven/Gradle.

## Modules

Expand All @@ -12,17 +12,15 @@ Module name below corresponds to the artifact name in Maven/Gradle.

## Contributing

Follow the following simple guidelines when contributing integration with your favorite library:
Follow the following simple guidelines when contributing an integration with your favorite library:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest removing this whatsoever -- we aren't really keen on accepting the brand-new integration modules in a fast-paced manner that requires a separate contribution guide


* Keep it simple and general. Ideally it should fit into a single file. If it does not fit, then consider
a separate GitHub project to host this integration.
* Keep it simple and general. Ideally, it should fit into a single file.
If it does not fit, consider a separate GitHub project for hosting this integration.
* Follow the example of other modules.
Cut-and-paste [kotlinx-coroutines-guava](kotlinx-coroutines-guava) module as a template.
* Write tests and documentation, include top-level `README.md` with short overview and example.
Copy-and-paste [kotlinx-coroutines-guava](kotlinx-coroutines-guava) module as a template.
* Write tests and documentation, include a top-level `README.md` with a short overview and an example.
* Reference the new module from all the places:
* List of modules in this document.
* List of modules in top-level [`settings.gradle`](../settings.gradle).
* List of modules at the root of documentation site in [`site/docs/index.md`](../site/docs/index.md).
* List of modules in the top-level [`settings.gradle`](../settings.gradle).
* List of integrations in the root [README.md](../README.md).
* Update links to documentation website as explained [here](../knit/README.md#usage).
* Squash your contribution to a single commit and create pull request to `develop` branch.
* Create a pull request to the `develop` branch.