Adjust Gradle configuration to gradually introduce warnings as errors… #3466
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… in a safe manner * Also, add tests that verify our disabled assertions * Fix nullability in AgentPremain that used to work by accident (because we disabled those assertions)
|
I'll leave |
qwwdfsad
commented
Sep 27, 2022
| @@ -2,6 +2,8 @@ | |||
| * Copyright 2016-2021 JetBrains s.r.o. Use of this source code is governed by the Apache 2.0 license. | |||
| */ | |||
|
|
|||
| @file:Suppress("UNCHECKED_CAST", "UNUSED_PARAMETER") | |||
There was a problem hiding this comment.
I'm typically strongly against that, but this whole file is removed in fast-channels branch, so there are no issues with it here
buildSrc/src/main/kotlin/configure-compilation-conventions.gradle.kts
Outdated
Show resolved
Hide resolved
|
Works for me, good to go? |
|
Sure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… in a safe manner