Skip to content

Allow customization of default scheduler name on JVM #3465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 28, 2022

Conversation

IgnatBeresnev
Copy link
Member

Fixes #3231

@IgnatBeresnev
Copy link
Member Author

IgnatBeresnev commented Sep 26, 2022

Didn't find any documentation for existing configurable properties (such as kotlinx.coroutines.scheduler.max.pool.size).

On one hand, I think it's useful and can be added to Dispatchers and threads section under Dispatchers.Default heading, for instance

On the other, maybe it's not desirable to advertise these properties? It only works on JVM, and the majority of users probably don't need it.

Wdyt? I can add documentation for all current properties if requested.


Also, didn't find an easy way to write a unit/integration test for setting the name. Tell me if there's a way and I'm missing something :) I know there's a long way with configuring gradle tasks, but it doesn't seem rational for this type of change.

Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We typically do not advertise these properties, yes. The overwhelming majority of users never need to even think about them, and we're trying to keep the documentation relevant.

Also, yes, we don't write integration tests for these, they are very self-evident and are part of code that barely ever changes. It's enough to check manually if the property works.

@qwwdfsad qwwdfsad removed their request for review September 27, 2022 12:16
@dkhalanskyjb dkhalanskyjb merged commit dc58806 into develop Sep 28, 2022
@dkhalanskyjb dkhalanskyjb deleted the 3231_customizable-default-scheduler-name branch September 28, 2022 15:04
@dkhalanskyjb
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants