Preparation for atomicfu JVM IR plugin application in 1.7.20 #3455
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
exclude metadata when checking classes bytecode for ATOMIC_REF
mvicsokolova
commented
Sep 19, 2022
qwwdfsad
requested changes
Sep 19, 2022
integration-testing/src/mavenTest/kotlin/MavenPublicationAtomicfuValidator.kt
Outdated
Show resolved
Hide resolved
mvicsokolova
added a commit
that referenced
this pull request
Oct 12, 2022
* Fix for integration-testing:mavenTest: exclude metadata when checking classes bytecode for ATOMIC_REF * Moved SegmentBasedQueue implementation to the main module * Removed SegmentListTest
mvicsokolova
added a commit
that referenced
this pull request
Oct 12, 2022
* Fix for integration-testing:mavenTest: exclude metadata when checking classes bytecode for ATOMIC_REF * Moved SegmentBasedQueue implementation to the main module * Removed SegmentListTest
mvicsokolova
added a commit
that referenced
this pull request
Oct 13, 2022
* Fix for integration-testing:mavenTest: exclude metadata when checking classes bytecode for ATOMIC_REF * Moved SegmentBasedQueue implementation to the main module * Removed SegmentListTest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
testNoAtomicfuInMppJar)Used this solution instead of adding post transformation of metadata by
AtomicfuGradlePlugin, because the problem is on the side of the compiler plugin: it transforms the backing field of the property, though the property itself remains in the metadata. So, when I'll fix that in the compiler plugin, there will be no atomicfu references left in the metadata.SegmentBasedQueueclass that used inline atomic extension (findSegmentAndMoveForward) to the main module.Here is the sample coroutines build with Integration Test step