Skip to content

Get rid of workaround for KT-16222 that is long time fixed #3446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2022
Merged

Get rid of workaround for KT-16222 that is long time fixed #3446

merged 2 commits into from
Sep 9, 2022

Conversation

qwwdfsad
Copy link
Collaborator

@qwwdfsad qwwdfsad commented Sep 8, 2022

The correctness of the change is verified by ConsumeAsFlowLeakTest

@qwwdfsad
Copy link
Collaborator Author

qwwdfsad commented Sep 8, 2022

And a bit of warnings removal here and there

dkhalanskyjb
dkhalanskyjb approved these changes Sep 9, 2022
View reviewed changes
Copy link
Collaborator

@dkhalanskyjb dkhalanskyjb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Irrelevant musings) Before I read the actual code we're removing, I thought that this PR was just a trojan horse containing a clean-up of warnings and KT-16222 is just a pretense, but then, oh, wow, this is nasty. Great call purging it!

@qwwdfsad qwwdfsad merged commit 4e97c83 into develop Sep 9, 2022
@qwwdfsad qwwdfsad deleted the cleanup branch September 9, 2022 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkhalanskyjb dkhalanskyjb dkhalanskyjb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qwwdfsad @dkhalanskyjb