Skip to content

Ensure awaitFrame() only awaits a single frame when used from the main looper #3437

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 16, 2022
Merged

Ensure awaitFrame() only awaits a single frame when used from the main looper #3437

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
95892c2
Ensure `awaitFrame()` only awaits a single frame when used from the m…
pablobaxter Sep 2, 2022
0768ee5
~cleanup
qwwdfsad Sep 6, 2022
dcd2c04
~cleanup test
qwwdfsad Sep 15, 2022
51436d6
~
qwwdfsad Sep 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions ui/kotlinx-coroutines-android/test/HandlerDispatcherTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,9 +116,7 @@ class HandlerDispatcherTest : TestBase() {
mainLooper.runOneTask()
expect(4)
mainLooper.scheduler.advanceBy(50, TimeUnit.MILLISECONDS)
expect(5)
mainLooper.scheduler.advanceBy(51, TimeUnit.MILLISECONDS)
finish(6)
finish(5)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it's finish(4), as the action after expect(4) also does nothing.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

}

private fun CoroutineScope.doTestAwaitWithDetectedChoreographer() {
Expand Down