Ensure awaitFrame() only awaits a single frame when used from the main thread
#3431
Conversation
| return suspendCancellableCoroutine { cont -> | ||
| Dispatchers.Main.dispatch(EmptyCoroutineContext, Runnable { | ||
| if (Looper.myLooper() === Looper.getMainLooper()) { // Check if we are already in the main looper thread |
There was a problem hiding this comment.
Thanks!
I'm not yet convinced this should be the solution though.
I would expect that Dispatchers.Main.immediate would be enough, but it is not due to our implementation details.
We'll fix it in the next release, but it is an open question whether we are going to use this particular approach though
There was a problem hiding this comment.
No probs!
The only reason I took the Looper approach here is because this code is specific to Android, and I didn't see anything similar for JavaFX or Swing implementations (awaitPulse() was the closest parallel). I see no problems and I am not opposed to using Dispatchers.Main.immediate.
There was a problem hiding this comment.
It seems to be the way though!
I've opened #3437 with a few changes on top of yours that I'll squash into your commit. Thanks for the contribution, we'll merge it in the next release!
Fix to resolve #3432