Fix channel BufferOverflow behavior #3331
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
Jun 22, 2022
There was a problem hiding this comment.
Sorry, but I can neither accept this PR nor guide you through the whole contribution process here:
- It will be postponed to 1.7.0, so we cannot merge it and have to keep it unmerged for a while, while keeping it in sync
- It requires a lot of analysis to do (e.g. it doesn't work for
capacity = 0for now and probably there are other places that have to be thoughtfully checked) - More importantly, we are in the process of rewriting the core of our channels Introduce fast and scalable channels #3103. It's all in progress and it will be really tough to keep this work in sync with develop
Sorry for the inconvenience and thanks for the effort
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes unexpected behavior #3330