Make the mavenTest integration test more robust #3315
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now, it checks explicitly that the classes it analyzes were taken from the local Maven repository. Additionally, the build script was tweaked so that accidentally setting the dependencies for this subproject is ignored.
dkhalanskyjb
commented
Jun 7, 2022
| classpath += mavenTestClasspathConfiguration | ||
| /* the order is this way because the first match is used, and if we ever accidentally add the wrong dependencies to | ||
| this source-set, they shouldn't override the dependencies to the local Maven repository */ | ||
| classpath = mavenTestClasspathConfiguration + classpath |
There was a problem hiding this comment.
With this, I was unable to make the new check fail, even trying to specify the dependencies for this source set in various places.
|
Is it left as a draft intentionally? |
|
Yes. If we decide to make |
mvicsokolova
force-pushed
the
integration-test-branch
branch
from
3dcca74 to
d8bc9e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now, it checks explicitly that the classes it analyzes were taken
from the local Maven repository. Additionally, the build script was
tweaked so that accidentally setting the dependencies for this
subproject is ignored.