-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Integration test project #3307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Integration test project #3307
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
ba4a93d
integration-test
mvicsokolova f204b21
~comment
qwwdfsad 0f9d689
Regenerated gradle wrapper
mvicsokolova f68953a
Removed dev repo, mavenLocal() is enough
mvicsokolova 9d0ac0e
A common test added
mvicsokolova 8e09712
Update version in integration-test by bump-version.sh
mvicsokolova ec04fa9
build.gradle fix
mvicsokolova 3754a2c
Integration-testing removed from subprojects, npmTest deleted
mvicsokolova fa1ac5f
gradle wrapper for integration-testing
mvicsokolova a51ab66
Simplify mavenTest config
mvicsokolova 5b42bd7
smokeTest added as a subproject to integration-testing
mvicsokolova d8bc9e4
Fixed getting a jar file from the classpath
mvicsokolova 66af8a0
Minor fixes
mvicsokolova 2669b2c
Remove comment
mvicsokolova ad5425f
debugAgentTest fix: find and overwrite DebugProbesKt.bin
mvicsokolova 67936ac
Fix for getting the path of DebugProbesKt.bin
mvicsokolova d50c23d
Read and rewrite DebugProbesKt.bin
mvicsokolova fa41006
README.md updated
mvicsokolova File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,14 +1,13 @@ | ||
# Integration tests | ||
|
||
This is a supplementary subproject of kotlinx.coroutines that provides | ||
integration tests. | ||
This is a supplementary project that provides integration tests. | ||
|
||
The tests are the following: | ||
* `NpmPublicationValidator` tests that version of NPM artifact is correct and that it has neither source nor package dependencies on atomicfu | ||
In order for the test to work, one needs to run gradle with `-PdryRun=true`. | ||
`-PdryRun` affects `npmPublish` so that it only provides a packed publication | ||
and does not in fact attempt to send the build for publication. | ||
* `MavenPublicationValidator` depends on the published artifacts and tests artifacts binary content and absence of atomicfu in the classpath | ||
* `MavenPublicationValidator` depends on the published artifacts and tests artifacts binary content and absence of atomicfu in the classpath. | ||
* `CoreAgentTest` checks that `kotlinx-coroutines-core` can be run as a Java agent. | ||
* `DebugAgentTest` checks that the coroutine debugger can be run as a Java agent. | ||
* `smokeTest` builds the test project that depends on coroutines. | ||
|
||
All the available tests can be run with `integration-testing:test`. | ||
The `integration-testing` project is expected to be in a subdirectory of the main `kotlinx.coroutines` project. | ||
|
||
To run all the available tests: `cd integration-testing` + `./gradlew check`. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
kotlin_version=1.6.21 | ||
coroutines_version=1.6.2-SNAPSHOT | ||
|
||
kotlin.code.style=official |
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
distributionBase=GRADLE_USER_HOME | ||
distributionPath=wrapper/dists | ||
distributionUrl=https\://services.gradle.org/distributions/gradle-7.4.2-all.zip | ||
zipStoreBase=GRADLE_USER_HOME | ||
zipStorePath=wrapper/dists |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now, that's an issue.
This flag control the functionality in
integration-testing/src/debugAgentTest/kotlin/PrecompiledDebugProbesTest.kt
that allows us to replaceDebugProbesKt.bin
, a file in the repository, with a new version. I'm sure this functionality is now broken. We should either fix this or adapt in some other way. @qwwdfsad, do we still need-Poverwrite.probes
? Does anyone rely but us on this, or can we provide a more fitting interface? Also, is the comment below still relevant (from the file with the test)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment is indeed redundant.
Right. @mvicsokolova please ensure that
./gradlew debugAgentTest -Poverwrite.probes=true
properly works. For now it fails withFileNotFoundException
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from that,
./gradlew publishToMavenLocal
+cd integration-testing
+./gradlew debugAgentTest
fails locally atPrecompiledDebugProbesTest
. It shouldn't be be the case, please investigate