Remove TestCoroutineContext.kt completely #3291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkhalanskyjb
requested changes
May 23, 2022
| @@ -77,9 +77,6 @@ public class CoroutinesBlockHoundIntegration : BlockHoundIntegration { | |||
| for (method in listOf("clear", "peek", "removeFirstOrNull", "addLast")) { | |||
| allowBlockingCallsInside("kotlinx.coroutines.internal.ThreadSafeHeap", method) | |||
| } | |||
| // [addLastIf] is only used in [EventLoop.common]. Users of [removeFirstIf]: | |||
| allowBlockingCallsInside("kotlinx.coroutines.test.TestCoroutineDispatcher", "doActionsUntil") | |||
| allowBlockingCallsInside("kotlinx.coroutines.test.TestCoroutineContext", "triggerActions") | |||
There was a problem hiding this comment.
Not directly related, but looking at this, I don't know how I feel about it being forbidden to do the test module's runCurrent and advance* from Dispatchers.Default when BlockHound is used, even if the operations themselves are completely fine. I don't think this is a realistic concern, but it still feels a bit semantically unclean.
qwwdfsad
force-pushed
the
remove-test-context
branch
from
0510294 to
f0260ba
Compare
dkhalanskyjb
approved these changes
May 23, 2022
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While we typically avoid breaking experimental API in minor releases, even if we're allowed to, this one seems to be acceptable. It was obsolete since the very 1.0.0 and was never integrated into structured concurrency, and on the other side it prevents using
kotlinx-coroutines-corealong withkotlinx-coroutines-testin a modularized environment due to split packagekotlinx.coroutines.test.Fixes #3218