Delegate properties to atomics #3265
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qwwdfsad
reviewed
Apr 28, 2022
| @@ -104,9 +104,7 @@ private class AwaitAll<T>(private val deferreds: Array<out Deferred<T>>) { | |||
| lateinit var handle: DisposableHandle | |||
|
|
|||
| private val _disposer = atomic<DisposeHandlersOnCancel?>(null) | |||
| var disposer: DisposeHandlersOnCancel? | |||
There was a problem hiding this comment.
while we are here, it seems like it should just be
@Volatile
private var disposer: DisposeHandlersOnCancel? = null
| @@ -62,6 +62,7 @@ public class kotlinx/coroutines/CancellableContinuationImpl : kotlin/coroutines/ | |||
| public fun getContinuationCancellationCause (Lkotlinx/coroutines/Job;)Ljava/lang/Throwable; | |||
| public final fun getResult ()Ljava/lang/Object; | |||
| public fun getStackTraceElement ()Ljava/lang/StackTraceElement; | |||
| public final fun getState$kotlinx_coroutines_core ()Ljava/lang/Object; | |||
There was a problem hiding this comment.
Please investigate why these getters are now considered public. It seems like a specific attribute is missing from metadata
|
Any update about this one? |
mvicsokolova
force-pushed
the
atomicfu-delegated
branch
from
34483fd to
d3e718e
Compare
mvicsokolova
force-pushed
the
atomicfu-delegated
branch
from
d3e718e to
4b456cc
Compare
|
Depends on this: #3501 |
|
There was a bug revealed on JS IR side with Kotlin The fix in the compiler plugin will be provided with Kotlin |
|
jvm-ir transformer along with 1.8.10 Kotlin are in |
|
Can be opened as a new PR to avoid restoring all the context incrementally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.