docs: Update Coroutine context and dispatchers doc #3202
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think flipping the order of the print and delay makes it more clear that one coroutine is canceled while the other lives on. Also I added a note that explains why the delay is necessary. The need for the second delay wasn't immediately clear to me on first read of the coroutine guide.
qwwdfsad
added a commit
that referenced
this pull request
May 18, 2022
|
Thanks for the idea! Opened #3292 with a full update |
qwwdfsad
added a commit
that referenced
this pull request
May 19, 2022
* Update guide example to better reflect the intent Based on #3202
pablobaxter
pushed a commit
to pablobaxter/kotlinx.coroutines
that referenced
this pull request
Sep 14, 2022
* Update guide example to better reflect the intent Based on Kotlin#3202
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think flipping the order of the print and delay makes it more clear that one coroutine is canceled while the other lives on. Also I added a note that explains why the delay is necessary. The need for the second delay wasn't immediately clear to me on first read of the coroutine guide.