Skip to content

Remove SubscriptionReceiveChannel #311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

deva666
Copy link
Contributor

@deva666 deva666 commented Apr 4, 2018

#283 Issue says that SubscriptionReceiveChannel should be removed, so this PR is a breaking change. Not sure if this is wanted?

@elizarov
Copy link
Contributor

That is Ok. It is supposed to be breaking change in the source. However, for binary compatibility we need to keep old SubscrpitonReceiveChannel interface (as deprecated), keep old openSubscription function (as deprecated/hidden), so new openSubscription will probably have to use a different @JvmName.

Also, can you please rebase your changes onto the latest develop branch.

@deva666 deva666 force-pushed the remove_SubscriptionReceiveChannel branch from fb762ce to 0062cb2 Compare April 11, 2018 19:07
@deva666
Copy link
Contributor Author

deva666 commented Apr 11, 2018

@elizarov not sure how you can apply JvmName annotation in this case. And of course, there can't be two functions with different return types. If we deprecate the old openSubscription function can the new one be named differently, something like openReceiveChannel ?

@elizarov
Copy link
Contributor

Hm... I checked. Indeed, I cannot seem to find a way to preserve binary compatibility when changing return type. This is bad: https://youtrack.jetbrains.com/issue/KT-23750

@elizarov
Copy link
Contributor

I've found a way to preserve binary compatibility. Merged this PR into develop.

@elizarov elizarov closed this May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants